Changeset 80

Timestamp:

04/17/06 09:21:47 (3 years ago)

Author:

jordi

Message:

All setters function from IDocument now frees the argumen after copying it to the attribute. That's because I though that a "double free or invalid pointer" was caused by any of them, but it seems that it was the test code that did pass a const char, when a copy of it should have been passed. This didn't happen on "debug mode"...

Location:

trunk

Files:

• src/IDocument.cxx (modified) (10 diffs)
• tests/MainPterTest.cxx (modified) (1 diff)

trunk/src/IDocument.cxx

@@ -188 +188 @@
 IDocument::setTitle (gchar *title)
 {
-    g_free (m_Title);
-    m_Title = title;
+    gchar *oldTitle = m_Title;
+    m_Title = g_strdup (title);
+    g_free (oldTitle);
+    g_free (title);
 }
 
@@ -216 +218 @@
 IDocument::setAuthor (gchar *author)
 {
-    g_free (m_Author);
-    m_Author = author;
+    gchar *oldAuthor = m_Author;
+    m_Author = g_strdup (author);
+    g_free (oldAuthor);
+    g_free (author);
 }
 
@@ -244 +248 @@
 IDocument::setSubject (gchar *subject)
 {
-    g_free (m_Subject);
+    gchar *oldSubject = m_Subject;
+    m_Subject = g_strdup (subject);
+    g_free (oldSubject);
     m_Subject = subject;
 }
@@ -273 +279 @@
 IDocument::setKeywords (gchar *keywords)
 {
-    g_free (m_Keywords);
-    m_Keywords = keywords;
+    gchar *oldKeywords = m_Keywords;
+    m_Keywords = g_strdup (keywords);
+    g_free (oldKeywords);
+    g_free (keywords);
 }
 
@@ -302 +310 @@
 IDocument::setCreator (gchar *creator)
 {
-    g_free (m_Creator);
-    m_Creator = creator;
+    gchar *oldCreator = m_Creator;
+    m_Creator = g_strdup (creator);
+    g_free (oldCreator);
+    g_free (creator);
 }
 ///
@@ -330 +340 @@
 IDocument::setProducer (gchar *producer)
 {
-    g_free (m_Producer);
-    m_Producer = producer;
+    gchar *oldProducer = m_Producer;
+    m_Producer = g_strdup (producer);
+    g_free (oldProducer);
+    g_free (producer);
 }
 
@@ -360 +372 @@
 IDocument::setFormat (gchar *format)
 {
-    g_free (m_Format);
-    m_Format = format;
+    gchar *oldFormat = m_Format;
+    m_Format = g_strdup (format);
+    g_free (oldFormat);
+    g_free (format);
 }
 
@@ -390 +404 @@
 IDocument::setLinearized (gchar *linearized)
 {
-    g_free (m_Linearized);
-    m_Linearized = linearized;
+    gchar *oldLinearized = m_Linearized;
+    m_Linearized = g_strdup (linearized);
+    g_free (oldLinearized);
+    g_free (linearized);
 }
 
@@ -419 +435 @@
 IDocument::setCreationDate (gchar *date)
 {
-    g_free (m_CreationDate);
-    m_CreationDate = date;
+    gchar *oldCreationDate = m_CreationDate;
+    m_CreationDate = g_strdup (date);
+    g_free (oldCreationDate);
+    g_free (date);
 }
 
@@ -448 +466 @@
 IDocument::setModifiedDate (gchar *date)
 {
-    g_free (m_ModifiedDate);
-    m_ModifiedDate = date;
+    gchar *oldModifiedDate = m_ModifiedDate;
+    m_ModifiedDate = g_strdup (date);
+    g_free (oldModifiedDate);
+    g_free (date);
 }
 

trunk/tests/MainPterTest.cxx

@@ -112 +112 @@
 
     // Now try a document with a title.
-    m_Document->setTitle ("Test PDF");
+    m_Document->setTitle (g_strdup ("Test PDF"));
     m_MainPter->openFileActivated ();
     CPPUNIT_ASSERT_EQUAL (0,