Ticket #10 (closed defect: fixed)

Opened 2 years ago

Last modified 21 months ago

Incomplete keyboard support

Reported by: anonymous Owned by: Jordi
Priority: trivial Version: 0.1.3
Keywords: Cc:

Description

MainView.cxx (1153):

/// @brief The page view has been scrolled.
///
/// This only happends when the user uses the mouse wheel.

This should be a bug. It would be great if keyboard support were vastly enhanced. The page area should be able to get the focus and be scrolled with Up/Down or other keys, in addition to the PgUp/Dn bindings. Not just this, but with every action having a default (and a configurable) binding. This is partly taste (enhancement, perhaps), and partly accessibility (defect).

Attachments

epdfview-0.1.4-scrolling.patch (4.1 kB) - added by LoneFox 2 years ago.
A patch that makes the keyboard scrolling work as expected by most users.

Change History

Changed 2 years ago by jordi

This comments tries to mean that only when the mouse wheel has scrolled the page all up or all down it changes to the previous or next page respectively.

For now I have disabled this bevaviour because I want to implement a continuous mode just like Acrobat Adobe Reader does.

What I have done is letting the scrolled window where the page is shown grab the keybord focus, so it's possible to scroll the page using the default's GTK+ bindings (the same for each GTK+ application) except for the binding that are already taken (i.e., PgUp?, PgDown?, Ctrl+Home and Ctrl+End).

I also don't think that each action should have a binding, just only the more freqüent: I don't see the point on adding a binding to show/hide the toolbar or the status bar. If you really need to do this using the keyboard each menu and menu item already has a mnemonic.

Changed 2 years ago by LoneFox

A patch that makes the keyboard scrolling work as expected by most users.

Changed 2 years ago by jordi

  • status changed from new to closed
  • resolution set to fixed

I applied the patch ([188]) and it works perfectly, thank you very much.

Note: See TracTickets for help on using tickets.